Project

General

Profile

Actions

Bug #4218

closed

FTP asan leak

Added by Peter Manev over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Affected Versions:
Effort:
Difficulty:
Label:

Description

In relation to
https://redmine.openinfosecfoundation.org/issues/3597
I still get with 7.x gitmaster

Direct leak of 3360 byte(s) in 105 object(s) allocated from:
    #0 0x58b6aa in calloc (/opt/suritest-tmp/bin/suricata+0x58b6aa)
    #1 0xc6a6c9 in SCCallocFunc /opt/suricata/src/util-mem.c:57:20
    #2 0x65e993 in FTPCalloc /opt/suricata/src/app-layer-ftp.c:217:17
    #3 0x65a0f7 in FTPParseRequest /opt/suricata/src/app-layer-ftp.c:637:51
    #4 0x693a77 in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1273:30
    #5 0x5d26a6 in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:706:17
    #6 0xb756ee in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1175:15
    #7 0xb7381b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1238:12
    #8 0xb7b5c7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1809:9
    #9 0xb7b250 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1852:9
    #10 0xb500db in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #11 0xb11dd9 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #12 0xaf4ef9 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #13 0xaeb5e9 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #14 0xaf60fc in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #15 0x99d097 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #16 0x99bfdd in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #17 0xba594e in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #18 0xac6a72 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #19 0xabf960 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #20 0xabdfd7 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #21 0xab5900 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #22 0xab34d7 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #23 0xbb31af in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #24 0x7faca0154fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 4476 byte(s) in 105 object(s) allocated from:
    #0 0x58b6aa in calloc (/opt/suritest-tmp/bin/suricata+0x58b6aa)
    #1 0xc6a6c9 in SCCallocFunc /opt/suricata/src/util-mem.c:57:20
    #2 0x65e993 in FTPCalloc /opt/suricata/src/app-layer-ftp.c:217:17
    #3 0x65a391 in FTPParseRequest /opt/suricata/src/app-layer-ftp.c:646:39
    #4 0x693a77 in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1273:30
    #5 0x5d26a6 in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:706:17
    #6 0xb756ee in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1175:15
    #7 0xb7381b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1238:12
    #8 0xb7b5c7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1809:9
    #9 0xb7b250 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1852:9
    #10 0xb500db in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #11 0xb11dd9 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #12 0xaf4ef9 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #13 0xaeb5e9 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #14 0xaf60fc in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #15 0x99d097 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #16 0x99bfdd in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #17 0xba594e in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #18 0xac6a72 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #19 0xabf960 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #20 0xabdfd7 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #21 0xab5900 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #22 0xab34d7 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #23 0xbb31af in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #24 0x7faca0154fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

SUMMARY: AddressSanitizer: 7836 byte(s) leaked in 210 allocation(s).

but now the only diff I see is

    #1 0xc6a6c9 in SCCallocFunc /opt/suricata/src/util-mem.c:57:20

Actions #2

Updated by Philippe Antoine over 1 year ago

  • Status changed from New to Closed

Closing as duplicate, feel free to reopen if you still see this

Actions

Also available in: Atom PDF