https://redmine.openinfosecfoundation.org/https://redmine.openinfosecfoundation.org/favicon.ico?17011170022021-06-08T08:19:30ZOpen Information Security FoundationSuricata - Optimization #4475: Rust: Make default_port in parser registration an Optionhttps://redmine.openinfosecfoundation.org/issues/4475?journal_id=200822021-06-08T08:19:30ZShivani Bhardwaj
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-5 priority-5 priority-high3 closed" href="/issues/3315">Optimization #3315</a>: app-layer: unify registration logic</i> added</li></ul> Suricata - Optimization #4475: Rust: Make default_port in parser registration an Optionhttps://redmine.openinfosecfoundation.org/issues/4475?journal_id=202322021-06-26T11:04:43ZShivani Bhardwaj
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>In Review</i></li></ul><p>Seems like using Option for `*const i8` is not FFI safe and Rust warns about it.<br />Using a null string in place of default port does seem to do the work though. Changed it in DCERPC only for now where there is not a fixed port of communication.<br />PR for review: <a class="external" href="https://github.com/OISF/suricata/pull/6234">https://github.com/OISF/suricata/pull/6234</a></p> Suricata - Optimization #4475: Rust: Make default_port in parser registration an Optionhttps://redmine.openinfosecfoundation.org/issues/4475?journal_id=207282021-09-21T09:27:39ZShivani Bhardwaj
<ul><li><strong>Status</strong> changed from <i>In Review</i> to <i>Closed</i></li></ul><p>Closed by PR: <a class="external" href="https://github.com/OISF/suricata/pull/6350">https://github.com/OISF/suricata/pull/6350</a></p>