Project

General

Profile

Actions

Documentation #7298

open

Documentation #6478: schema: add missing fields

schema/netflow: add missing field

Added by Juliana Fajardini Reichow about 2 months ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:
Beginner, Good First Issue, Outreachy

Description

Running

git grep 'js, "' src/output-json-netflow.c | cut -d'"' -f2 | sort | uniq | while read i; do echo -n $i " "; git grep $i etc/schema.json | wc -l; done

Will show that sesnsor_id comes with a 0, meaning we are missing this field in our json schema.

https://github.com/OISF/suricata/pull/11844 showcases how a similar issue (#7287) was fixed.

Actions #1

Updated by Philippe Antoine about 2 months ago

I see three fields missing besides DNP3 :

git grep 'js, "' src/output-json-*.c | grep -v dnp3 | cut -d'"' -f2 | sort | uniq | while read i; do echo -n $i; git grep $i etc/schema.json | wc -l; done | awk '$2 == 0'
payload_hex       0
sensor_id       0
tenant_id       0

Actions

Also available in: Atom PDF