Project

General

Profile

Actions
Copy link

Bug #1064

closed
AL VJ

Lack of Thread Deinitialization For Decoder Modules

Bug #1064: Lack of Thread Deinitialization For Decoder Modules

Added by Amin Latifi over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Victor Julien
Target version:
2.0.1rc1
Affected Versions:
Effort:
Difficulty:
Label:

Description

I checked Suricata code and I found out that decoder thread modules don't set ThreadDeinit member of their TmModule in tmm_modules table.

It somehow doesn't seem normal. Since, decode threads have at least one member in their DecodeThreadVars which maybe should be deinitialized. Actually, I realized DecodeThreadVars contains AlpProtoDetectThreadCtx member and the AlpProtoDetectThreadCtx variables maybe should be deinitialized by using AlpProtoFinalize2Thread function; similar what happens in StreamTcpThreadDeinit (StreamTcp thread deinitializing) procedure.

So, I don't know the implementation of decoders' deinitialization has been missed mistakenly? or not implementing of that doesn't make any problem?

VJ Updated by Victor Julien over 12 years ago Actions
Copy link
 #1

Please, when adding a ticket based on an mailinglist conversation, add a link to that.
https://lists.openinfosecfoundation.org/pipermail/oisf-devel/2013-November/002794.html

VJ Updated by Victor Julien over 12 years ago Actions
Copy link
 #2

  • Estimated time deleted (2.00 h)

VJ Updated by Victor Julien about 12 years ago Actions
Copy link
 #3

  • Status changed from New to Closed
  • Assignee set to Victor Julien
  • Target version changed from TBD to 2.0.1rc1
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: PDF Atom