Actions
Bug #1336
closedmodbus: CID 1257762: Logically dead code (DEADCODE)
Affected Versions:
Effort:
Difficulty:
Label:
Description
*** CID 1257762: Logically dead code (DEADCODE)
/src/app-layer-modbus.c: 834 in ModbusParseDiagnosticRequest()
828
829 if (tx->subFunction != MODBUS_SUBFUNC_QUERY_DATA) {
830 switch (tx->subFunction) {
831 case MODBUS_SUBFUNC_RESTART_COM:
832 if ((data != 0x00) || (data != 0xFF00))
833 goto error;
CID 1257762: Logically dead code (DEADCODE)
Execution cannot reach this statement: "break;".
834 break;
835
836 case MODBUS_SUBFUNC_CHANGE_DELIMITER:
837 if ((data & 0xFF) != 0x00)
838 goto error;
839 break;
Updated by David DIALLO almost 11 years ago
- Status changed from New to Resolved
- Priority changed from Normal to Low
- % Done changed from 0 to 50
Updated by Victor Julien almost 11 years ago
- Description updated (diff)
- Status changed from Resolved to Closed
- % Done changed from 50 to 100
Actions