Project

General

Profile

Actions
Copy link

Bug #538

closed
RS

Feature #775: libhtp 0.5 support

suricata 1.3.1 fails to build when libhtp >= 0.3 is installed

Bug #538: suricata 1.3.1 fails to build when libhtp >= 0.3 is installed

Added by Ryan Steinmetz over 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Affected Versions:
Effort:
Difficulty:
Label:

Description

libhtp's table_getc() was renamed to table_get_c() in libhtp >= 0.3. This causes build failures whenever suricata is configured with --enable-non-bundled-htp.

The attached patch works around this issue, however, assumes that 0.3 is installed. The ideal solution would likely involve auto* checking to see if table_getc/table_get_c exists in the libhtp headers and defines the workaround if needed.

Files

Download all files
patch-src__suricata-common.h (447 Bytes) patch-src__suricata-common.h Ryan Steinmetz, 09/05/2012 09:43 PM
0001-Enable-libhtp-0.3.0-compilation-and-crash-free-UT-ru.patch (3.48 KB) 0001-Enable-libhtp-0.3.0-compilation-and-crash-free-UT-ru.patch Victor Julien, 10/05/2012 04:47 AM

VJ Updated by Victor Julien over 13 years ago Actions
Copy link
 #1

Right now Suricata requires and is tested with the 0.2.x branch. I had never tried 0.3, so I'm surprised you got it working with such a small effort. Can you run Suricata's unittests to see if they still all pass?

VJ Updated by Victor Julien over 13 years ago Actions
Copy link
 #2

  • Status changed from New to Assigned
  • Assignee set to Victor Julien
  • Target version set to 2.0rc2

VJ Updated by Victor Julien over 13 years ago Actions
Copy link
 #3

Have it mostly working. Found an issue in libhtp though: https://github.com/ironbee/libhtp/pull/30

Attached patch to suricata master enables compilation and crash free UT run, however still seeing 5 failed tests.

VJ Updated by Victor Julien about 13 years ago Actions
Copy link
 #4

  • Parent task set to #775

We're upgrading to 0.5 soon.

VJ Updated by Victor Julien over 12 years ago Actions
Copy link
 #5

  • Status changed from Assigned to Closed
  • Assignee deleted (Victor Julien)
  • Target version deleted (2.0rc2)
  • Estimated time changed from 1.00 h to 0.00 h

Closing as we're tracking the libhtp upgrade in #775.

Actions
Copy link

Also available in: PDF Atom