Bug #538
closedFeature #775: libhtp 0.5 support
suricata 1.3.1 fails to build when libhtp >= 0.3 is installed
Description
libhtp's table_getc() was renamed to table_get_c() in libhtp >= 0.3. This causes build failures whenever suricata is configured with --enable-non-bundled-htp.
The attached patch works around this issue, however, assumes that 0.3 is installed. The ideal solution would likely involve auto* checking to see if table_getc/table_get_c exists in the libhtp headers and defines the workaround if needed.
Files
Updated by Victor Julien over 11 years ago
Right now Suricata requires and is tested with the 0.2.x branch. I had never tried 0.3, so I'm surprised you got it working with such a small effort. Can you run Suricata's unittests to see if they still all pass?
Updated by Victor Julien over 11 years ago
- Status changed from New to Assigned
- Assignee set to Victor Julien
- Target version set to 2.0rc2
Updated by Victor Julien over 11 years ago
- File 0001-Enable-libhtp-0.3.0-compilation-and-crash-free-UT-ru.patch 0001-Enable-libhtp-0.3.0-compilation-and-crash-free-UT-ru.patch added
Have it mostly working. Found an issue in libhtp though: https://github.com/ironbee/libhtp/pull/30
Attached patch to suricata master enables compilation and crash free UT run, however still seeing 5 failed tests.
Updated by Victor Julien almost 11 years ago
- Status changed from Assigned to Closed
- Assignee deleted (
Victor Julien) - Target version deleted (
2.0rc2) - Estimated time changed from 1.00 h to 0.00 h
Closing as we're tracking the libhtp upgrade in #775.