Project

General

Profile

Actions

Optimization #565

closed

pattern id unused if uricontent and content+http_uri are mixed

Added by Victor Julien about 12 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

This appears to lead to unused pattern id. Due to to this pmq bitarray is bigger than necessary.

lert http $HOME_NET any -> $EXTERNAL_NET $HTTP_PORTS (msg:"ET CURRENT_EVENTS FakeAlert/FraudPack/FakeAV/Guzz/Dload/Vobfus/ZPack Encrypted GIF download 1"; flow:established,to_server; content:"GET "; depth:4; uricontent:"/perce/"; nocase; uricontent:"/qwerce.gif"; nocase; reference:url,threatinfo.trendmicro.com/vinfo/virusencyclo/default5.asp?VName=TROJ_AGENT.GUZZ&VSect=T; reference:url,www.threatexpert.com/threats/trojan-fraudpack-sd6.html; reference:url,vil.nai.com/vil/content/v_157489.htm; reference:url,blog.threatfire.com/2009/06/streamviewers-gif-images-embedded-with-encrypted-malware.html; reference:url,doc.emergingthreats.net/2010231; classtype:trojan-activity; sid:2010231; rev:6;)
alert http $HOME_NET any -> $EXTERNAL_NET any (msg:"ET CURRENT_EVENTS FakeAlert/FraudPack/FakeAV/Guzz/Dload/Vobfus/ZPack HTTP Post 2"; flow:established,to_server; content:"POST"; http_method; content:"/perce/"; nocase; http_uri; content:"/qwerce.gif"; http_uri; nocase; content:"data="; nocase; http_client_body; reference:url,threatinfo.trendmicro.com/vinfo/virusencyclo/default5.asp?VName=TROJ_AGENT.GUZZ&VSect=T; reference:url,www.threatexpert.com/threats/trojan-fraudpack-sd6.html; reference:url,vil.nai.com/vil/content/v_157489.htm; reference:url,doc.emergingthreats.net/2010235; classtype:trojan-activity; sid:2010235; rev:7;)

Actions #1

Updated by Anoop Saldanha about 12 years ago

If I print max_pattern_id, I get 5, which seems right to me.

Actions #2

Updated by Anoop Saldanha over 11 years ago

https://github.com/inliniac/suricata/pull/308

If at all this issue existed, this PR should make it disappear.

Actions #3

Updated by Anoop Saldanha over 11 years ago

Anoop Saldanha wrote:

https://github.com/inliniac/suricata/pull/308

If at all this issue existed, this PR should make it disappear.

Disregard above PR

https://github.com/inliniac/suricata/pull/316 contains the fix.

Actions #4

Updated by Victor Julien over 11 years ago

  • Status changed from Assigned to Closed
  • Target version changed from 2.0rc2 to 2.0beta1
Actions

Also available in: Atom PDF