Project

General

Profile

Actions

Bug #651

closed

Flow reference count is incremented twice, leading to memory and flow bucket leaks

Added by Ludovico Cavedon almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
High
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

The reference count of flows is sometimes incremented twice in the current stable release of suricata 1.3.4, once by FlowReference(), once by FlowIncrUsecnt()

See
https://github.com/cavedon/suricata/commit/49d6d4d8d672c51eec465c5cec4ff0c903af70e3
for the fix.

This does not affect the current master branch.

This looks like a major issue because flow buckets are leaked until no more buckets can be freed and suricata stalls at 100% CPU usage iterating over all flow buckets.

Actions #2

Updated by Victor Julien almost 9 years ago

  • Status changed from New to Closed
  • Assignee set to Ludovico Cavedon
  • % Done changed from 0 to 100

Great catch, thanks!

Merged pr/232.

Actions

Also available in: Atom PDF