Project

General

Profile

Actions
Copy link

Bug #652

closed

TCP sessions cleaned up prematurely

Added by Ludovico Cavedon over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Victor Julien
Target version:
1.4
Affected Versions:
Effort:
Difficulty:
Label:

Description

If one TCP endpoint closes the connection, but there are still TCP segments on the network that have not been received yet by suricata, these segments might not be processed.

The following patch delays the cleanup until the FIN form both side has been seen:
https://github.com/cavedon/suricata/commit/ac8b08771770ab0f0f5112c84c499771f5fb746e

This applies both to the master and the master-1.3.x branches.

Actions
Copy link
 #2

Updated by Victor Julien over 11 years ago

Can you share a pcap showing how this leads to problems?

Actions
Copy link
 #3

Updated by Victor Julien over 11 years ago

  • Status changed from New to Closed
  • Assignee set to Victor Julien
  • Target version set to 1.4

I've applied this to the master with a small addition: send eof on pseudo packets as well. Saw some missing logs in the http.log otherwise.

This has led me to the conclusion that it's a pretty major change that needs some more testing. So holding off on the 1.3 branch for now.

Actions
Copy link

Also available in: Atom PDF