Support #8328
openICMP error events are not reported
Description
I see suricata is not generating events for ICMP error messages due to the below code,
But I need to generate events for ICMP error messages.
if (PacketIsICMPv4(p)) {
if (ICMPV4_IS_ERROR_MSG(p->icmp_s.type)) {
return false;
}
}
#define ICMPV4_IS_ERROR_MSG(type) \
((type) ICMP_DEST_UNREACH || (type) ICMP_SOURCE_QUENCH || (type) ICMP_REDIRECT || \
(type) ICMP_TIME_EXCEEDED || (type) == ICMP_PARAMETERPROB)
Is this done intentionally?
Files
Updated by Rajkumar K about 12 hours ago
Victor Julien wrote in #note-1:
Can you share a test case?
Its a plain ICMP error, which is not associated with any ICMP requests as this is received on reaching tcp/udp port.
Running suricata, with only this packet in the pcap does not produce any event because of the above code
