Bug #979: clean up app layer protocol detection memory - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #979

closed

clean up app layer protocol detection memory

Added by Victor Julien over 10 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Anoop Saldanha

Target version:

2.0beta2

Affected Versions:

Effort:

Difficulty:

Label:

Description

Leak detectors go wild on this currently.

Error #36: LEAK 4 direct bytes 0x08e74f40-0x08e74f44 + 0 indirect bytes
# 0 replace_malloc                              [/work/drmemory_package/common/alloc_replace.c:2292]
# 1 B2gAddPattern                               [/home/victor/dev/oisf/src/util-mpm-b2g.c:312]
# 2 B2gAddPatternCS                             [/home/victor/dev/oisf/src/util-mpm-b2g.c:382]
# 3 AlpProtoAdd                                 [/home/victor/dev/oisf/src/app-layer-detect-proto.c:222]
# 4 RegisterSSHParsers                          [/home/victor/dev/oisf/src/app-layer-ssh.c:742]
# 5 RegisterAppLayerParsers                     [/home/victor/dev/oisf/src/app-layer-parser.c:1352]
# 6 AppLayerDetectProtoThreadInit               [/home/victor/dev/oisf/src/app-layer-detect-proto.c:342]
# 7 main                                        [/home/victor/dev/oisf/src/suricata.c:1853]

Error #37: LEAK 4 direct bytes 0x08e75350-0x08e75354 + 0 indirect bytes
# 0 replace_malloc                              [/work/drmemory_package/common/alloc_replace.c:2292]
# 1 B2gAddPattern                               [/home/victor/dev/oisf/src/util-mpm-b2g.c:312]
# 2 B2gAddPatternCS                             [/home/victor/dev/oisf/src/util-mpm-b2g.c:382]
# 3 AlpProtoAdd                                 [/home/victor/dev/oisf/src/app-layer-detect-proto.c:222]
# 4 RegisterSMTPParsers                         [/home/victor/dev/oisf/src/app-layer-smtp.c:850]
# 5 RegisterAppLayerParsers                     [/home/victor/dev/oisf/src/app-layer-parser.c:1353]
# 6 AppLayerDetectProtoThreadInit               [/home/victor/dev/oisf/src/app-layer-detect-proto.c:342]
# 7 main                                        [/home/victor/dev/oisf/src/suricata.c:1853]

This code is being rewritten. Added the ticket to make sure we address it in the new code.

Actions

Copy link

Updated by Victor Julien over 10 years ago

Another:

Error #28: LEAK 28 direct bytes 0x08e72ea8-0x08e72ec4 + 56 indirect bytes
# 0 replace_malloc                                            [/work/drmemory_package/common/alloc_replace.c:2292]
# 1 AppLayerInsertNewProbingParserSingleElement               [/home/victor/dev/oisf/src/app-layer-parser.c:1584]
# 2 AppLayerInsertNewProbingParserElement                     [/home/victor/dev/oisf/src/app-layer-parser.c:1703]
# 3 AppLayerRegisterProbingParser                             [/home/victor/dev/oisf/src/app-layer-parser.c:1945]
# 4 RegisterSSLParsers                                        [/home/victor/dev/oisf/src/app-layer-ssl.c:1027]
# 5 RegisterAppLayerParsers                                   [/home/victor/dev/oisf/src/app-layer-parser.c:1345]
# 6 AppLayerDetectProtoThreadInit                             [/home/victor/dev/oisf/src/app-layer-detect-proto.c:342]
# 7 main                                                      [/home/victor/dev/oisf/src/suricata.c:1853]

Actions

Copy link