Project

General

Profile

Actions
Copy link

Bug #115

closed
VJ AS

detect.alert counter never incremented

Bug #115: detect.alert counter never incremented

Added by Victor Julien about 16 years ago. Updated almost 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Anoop Saldanha
Target version:
0.9.2
Affected Versions:
Effort:
Difficulty:
Label:

Description

The detect.alert counter is shown in the stats.log but is never incremented. It's meant to be incremented for each unique alert.

Files

0001-fix-for-bug-115.patch (18.1 KB) 0001-fix-for-bug-115.patch Anoop Saldanha, 04/16/2010 01:11 AM

AS Updated by Anoop Saldanha about 16 years ago Actions
Copy link
 #1

  • Assignee changed from OISF Dev to Anoop Saldanha

Looks like the counter is registered, but it isn't being updated anywhere in the code.

AS Updated by Anoop Saldanha about 16 years ago Actions
Copy link
 #2

  • File 0001-bug-115-fix.patch added

attached a fix against 4494545d3a1257add4173af58c59fcaa1bf64b85.

VJ Updated by Victor Julien about 16 years ago Actions
Copy link
 #3

The numbers reported by this patch are off quite a bit. I think the best place to update the counter would be in PacketAlertAppend, as it is run after thresholding tests are done.

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #4

  • Due date changed from 03/12/2010 to 04/16/2010
  • Priority changed from Normal to Urgent

AS Updated by Anoop Saldanha almost 16 years ago Actions
Copy link
 #6

  • File deleted (0001-bug-115-fix.patch)

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #7

  • % Done changed from 0 to 70

Thanks Anoop, applied. I had to modify it to work with the reference keyword patch. I pushed out a master containing both.

Can you create another (incremental) patch against the current master that makes sure we have only one counter in the log (clubbing counter iirc)?

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #8

  • Due date changed from 04/16/2010 to 04/23/2010
  • Target version changed from 0.8.2 to 0.9.0

The clubbing counter work won't be ready in time, setting target to 0.9.0.

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #9

  • Priority changed from Urgent to Normal

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #10

  • Target version changed from 0.9.0 to 0.9.1

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #11

  • Target version changed from 0.9.1 to 0.9.2

VJ Updated by Victor Julien almost 16 years ago Actions
Copy link
 #12

  • Status changed from New to Closed
  • % Done changed from 70 to 100
  • Estimated time changed from 1.00 h to 4.00 h

Issue fully fixed in current master.

Actions
Copy link

Also available in: PDF Atom