Project

General

Profile

Actions
Copy link

Bug #1332

closed

cppcheck: ioctl

Added by Victor Julien over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Leblond
Target version:
2.1beta3
Affected Versions:
Effort:
Difficulty:
Label:

Description

[src/util-ioctl.c:226]: (error) Resource leak: fd
[src/util-ioctl.c:238]: (error) Mismatching allocation and deallocation: fd
[src/util-ioctl.c:241]: (error) Mismatching allocation and deallocation: fd

Actions
Copy link
 #1

Updated by Eric Leblond over 9 years ago

It may be a false positive here. All returns are preceded by a close call with fd param but the first which is the case where we handle the failure. By the way, I've got no error with cppcheck 1.67 by running:

cppcheck --enable=all --force --inconclusive --std=posix  src/util-ioctl.c --quiet

Actions
Copy link
 #2

Updated by Victor Julien over 9 years ago

I wonder if the "Mismatching allocation and deallocation: fd" are about using 'close' instead of 'shutdown'?

Actions
Copy link
 #3

Updated by Victor Julien over 9 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

My cppcheck version was 1.64. I can confirm the issue is gone in 1.67.

Actions
Copy link

Also available in: Atom PDF