Project

General

Profile

Actions
Copy link

Bug #1472

closed
JG AG

Should 'goodsigs' be 'goodtotal' when checking if signatures were loaded in detect.c?

Bug #1472: Should 'goodsigs' be 'goodtotal' when checking if signatures were loaded in detect.c?

Added by John Griffith almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Alexander Gozman
Target version:
3.0RC1
Affected Versions:
Effort:
Difficulty:
Label:

Description

Around line 468 in detect.c, there is a check for goodsigs <=0...

...
    /* now we should have signatures to work with */
    if (goodsigs <= 0) {
        if (cntf > 0) {
            SCLogWarning(SC_ERR_NO_RULES_LOADED, "%d rule files specified, but no rule was loaded at all!", cntf);
    ...

Shouldn't this check be on goodtotal instead? Otherwise, the check only covers the number of rules loaded from the last rules file read, not all of them.

Actions
Copy link

Also available in: PDF Atom