Project

General

Profile

Actions

Bug #1472

closed

Should 'goodsigs' be 'goodtotal' when checking if signatures were loaded in detect.c?

Added by John Griffith almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Around line 468 in detect.c, there is a check for goodsigs <=0...

...
/* now we should have signatures to work with */
if (goodsigs <= 0) {
if (cntf > 0) {
SCLogWarning(SC_ERR_NO_RULES_LOADED, "%d rule files specified, but no rule was loaded at all!", cntf);
...

Shouldn't this check be on goodtotal instead? Otherwise, the check only covers the number of rules loaded from the last rules file read, not all of them.

Actions

Also available in: Atom PDF