Project

General

Profile

Actions
Copy link

Bug #150

closed

Supress AppLayerParse() errors emitted by SMB and DCERPC by returning 0 instead of -1 on nonfatal errors.

Added by Kirby Kuehl over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Kirby Kuehl
Target version:
0.9.1
Affected Versions:
Effort:
Difficulty:
Label:

Description

This issue was reported by William Metcalf and contained a private pcap used to reproduce and validate fix.

Files

0001-Return-0-instead-of-1-when-SMB-and-DCERPC-encounter-.patch (23.2 KB) 0001-Return-0-instead-of-1-when-SMB-and-DCERPC-encounter-.patch Kirby Kuehl, 05/06/2010 11:49 AM
Actions
Copy link
 #1

Updated by Kirby Kuehl over 14 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 90
Actions
Copy link
 #2

Updated by Victor Julien over 14 years ago

  • Target version set to 0.9.1

Thanks Kirby. Can you review my changes of commit 52cdfb332e615542571c2e730166223628200ef3 ?

Your patch had a compiler warning in NBSSParseHeader:
cc1: warnings being treated as errors
app-layer-smb.c: In function ‘NBSSParseHeader’:
app-layer-smb.c:779: error: control reaches end of non-void function
make2: *** [app-layer-smb.o] Error 1

Please confirm the correctness of my fix.

Actions
Copy link
 #3

Updated by Kirby Kuehl over 14 years ago

Yes, your fix looks correct. I do not know why the
if ((p - input < 0))

check was there in the first place. Consider this closed and thanks!

Actions
Copy link
 #4

Updated by Victor Julien over 14 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

Thanks Kirby!

Actions
Copy link

Also available in: Atom PDF