Bug #150
closed
Supress AppLayerParse() errors emitted by SMB and DCERPC by returning 0 instead of -1 on nonfatal errors.
Added by Kirby Kuehl almost 14 years ago.
Updated almost 14 years ago.
Description
This issue was reported by William Metcalf and contained a private pcap used to reproduce and validate fix.
Files
- Status changed from New to Resolved
- % Done changed from 0 to 90
- Target version set to 0.9.1
Thanks Kirby. Can you review my changes of commit 52cdfb332e615542571c2e730166223628200ef3 ?
Your patch had a compiler warning in NBSSParseHeader:
cc1: warnings being treated as errors
app-layer-smb.c: In function ‘NBSSParseHeader’:
app-layer-smb.c:779: error: control reaches end of non-void function
make2: *** [app-layer-smb.o] Error 1
Please confirm the correctness of my fix.
Yes, your fix looks correct. I do not know why the
if ((p - input < 0))
check was there in the first place. Consider this closed and thanks!
- Status changed from Resolved to Closed
- % Done changed from 90 to 100
Also available in: Atom
PDF