Added by Kirby Kuehl almost 16 years ago. Updated almost 16 years ago.
Description
This issue was reported by William Metcalf and contained a private pcap used to reproduce and validate fix.
Files
| 0001-Return-0-instead-of-1-when-SMB-and-DCERPC-encounter-.patch (23.2 KB) 0001-Return-0-instead-of-1-when-SMB-and-DCERPC-encounter-.patch | Kirby Kuehl, 05/06/2010 11:49 AM |
Thanks Kirby. Can you review my changes of commit 52cdfb332e615542571c2e730166223628200ef3 ?
Your patch had a compiler warning in NBSSParseHeader:
cc1: warnings being treated as errors
app-layer-smb.c: In function ‘NBSSParseHeader’:
app-layer-smb.c:779: error: control reaches end of non-void function
make2: *** [app-layer-smb.o] Error 1
Please confirm the correctness of my fix.
Yes, your fix looks correct. I do not know why the
if ((p - input < 0))
check was there in the first place. Consider this closed and thanks!
Thanks Kirby!