Bug #2740: Bug #2714 was closed without the corresponding fix being applied in Suricata 4.1 - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #2740

closed

Bug #2714 was closed without the corresponding fix being applied in Suricata 4.1

Added by Bill Meeks over 5 years ago. Updated over 5 years ago.

Status:

Rejected

Priority:

Normal

Assignee:

Target version:

Affected Versions:

4.1beta1, 4.1rc1, 4.1rc2, 4.1.1

Effort:

Difficulty:

Label:

Description

Bug #2714 (https://redmine.openinfosecfoundation.org/issues/2714) was fixed and closed against the Suricata 4.0.x branch. The referenced commit was https://github.com/OISF/suricata/commit/bfe3a4180cf77e828c8d700d44bba960e408c741.

However, the same bug exists in the Suricata 4.1.x branch in the same file (detect-engine-mpm.c) at line 1508.

    uint8_t *content = NULL;
    uint8_t content_len = 0;
    PatIntId max_id = 0;
    DetectFPAndItsId *struct_offset = (DetectFPAndItsId *)ahb;
    uint8_t *content_offset = ahb + struct_total_size;

This code should read as follows:

    uint8_t *content = NULL;
    uint16_t content_len = 0;
    PatIntId max_id = 0;
    DetectFPAndItsId *struct_offset = (DetectFPAndItsId *)ahb;
    uint8_t *content_offset = ahb + struct_total_size;