Project

General

Profile

Actions
Copy link

Bug #3006

closed
VJ SB

improve rule keyword alproto registration

Bug #3006: improve rule keyword alproto registration

Added by Victor Julien almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shivani Bhardwaj
Target version:
5.0rc1
Affected Versions:
Effort:
Difficulty:
Label:

Description

Improve DetectSignatureSetAppProto by setting the WARN_UNUSED macro on the function prototype and fix the warnings.

Replace all direct 'sets' of Signature::alproto from keyword registration.

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #1

  • Status changed from New to Assigned
  • Assignee changed from OISF Dev to Shivani Bhardwaj

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #2

I'm unable to understand the statement, "direct 'sets' of Signature::alproto from keyword registration", could you please make it clearer?

VJ Updated by Victor Julien over 6 years ago Actions
Copy link
 #3

With direct 'sets' I mean code like:

static int DetectHttpUriSetupSticky(DetectEngineCtx *de_ctx, Signature *s, const char *str)
{
    DetectBufferSetActiveList(s, g_http_uri_buffer_id);
    s->alproto = ALPROTO_HTTP;
    return 0;
}

Where Signature::alproto is set explicitly.

These cases should be replaced by calls to DetectSignatureSetAppProto. E.g.:

static int DetectHttpMethodSetupSticky(DetectEngineCtx *de_ctx, Signature *s, const char *str)
{
    if (DetectBufferSetActiveList(s, g_http_method_buffer_id) < 0)
        return -1;

    if (DetectSignatureSetAppProto(s, ALPROTO_HTTP) < 0)
        return -1;

    return 0;
}

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #4

  • Status changed from Assigned to Feedback

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Closed
Actions
Copy link

Also available in: PDF Atom