Project

General

Profile

Actions

Bug #379

closed

profiling broken on OpenBSD

Added by Victor Julien about 13 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Low
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

From oisf-users:

I am trying to build suricata 1.1 under OpenBSD 5.0 but make returns
these errors:

Making all in test
Making all in src
make  all-am
gcc -DHAVE_CONFIG_H -I. -I..  -I../libhtp   -I/usr/local/include 
-I/usr/local/include/libnet-1.1 -I/usr/local/include/libnet-1.1  -g -O2 
-Wextra -Wall -fno-strict-aliasing -fno-tree-pre -Wno-unused-parameter 
-std=gnu99 -D__OpenBSD__ -DHAVE_LIBNET11 -D_BSD_SOURCE -D__BSD_SOURCE 
-D__FAVOR_BSD -DHAVE_NET_ETHERNET_H -DLIBPCAP_VERSION_MAJOR=0 
-DPROFILING -MT suricata.o -MD -MP -MF .deps/suricata.Tpo -c -o 
suricata.o suricata.c
In file included from suricata.c:137:
util-profiling.h:34: error: thread-local storage not supported for this 
target
*** Error code 1

Stop in /tmp/oo/suricata-1.1/src (line 92 of /usr/share/mk/sys.mk).
*** Error code 1

Stop in /tmp/oo/suricata-1.1/src (line 700 of Makefile).
*** Error code 1

Stop in /tmp/oo/suricata-1.1 (line 353 of Makefile).
*** Error code 1

Stop in /tmp/oo/suricata-1.1 (line 260 of Makefile).

Profiling code uses some thread local storage.

Actions #1

Updated by Victor Julien over 12 years ago

  • Assignee changed from OISF Dev to Eric Leblond
  • Target version set to 1.4
Actions #2

Updated by Victor Julien about 12 years ago

  • Target version changed from 1.4 to 1.4beta3

We won't redesign the profiling code just for OpenBSD, so this ticket can be closed when we cleanly compile. Profiling just won't be supported on OpenBSD.

Maybe we can add a warning that a more recent compiler will support it or something.

Actions #3

Updated by Eric Leblond about 12 years ago

I've modified configure.ac to exit from configure if enable-profiling flag is used under OpenBSD.

The corresponding PR is here: https://github.com/inliniac/suricata/pull/162

Actions #4

Updated by Victor Julien about 12 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Merged, thanks Eric!

Actions

Also available in: Atom PDF