Task #4039
closedTask #2975: convert unittests to new FAIL/PASS API
Convert unittests to new FAIL/PASS API: detect-filesize.c
Description
There is relevant information about the FAIL/PASS conversion on the parent issue.
Please check that out! :)
Updated by Juliana Fajardini Reichow over 3 years ago
- Description updated (diff)
Updated by Haleema Khan about 2 years ago
Hi, I want to work on this.
I see that all the other tests can be easily converted but one of them seems to be a Suricata verify test.
Updated by Shivani Bhardwaj about 2 years ago
Haleema Khan wrote in #note-2:
Hi, I want to work on this.
I see that all the other tests can be easily converted but one of them seems to be a Suricata verify test.
Please go ahead. :)
Try to keep only 2 tickets open (i.e. something that is still in the works and has not been approved by any mentor) at once to make sure that we leave tasks for others and are also not overwhelmed by too many open tickets.
Updated by Haleema Khan about 2 years ago
Thanks, Shivani!
Is it ok to pick a ticket if the others assigned are in review as there might be multiple iterations? Or do we wait until the final one?
Updated by Haleema Khan about 2 years ago
- Status changed from New to In Progress
- Assignee changed from Community Ticket to Haleema Khan
Updated by Haleema Khan about 2 years ago
- Status changed from In Progress to In Review
PR for review https://github.com/OISF/suricata/pull/8070
Updated by Shivani Bhardwaj about 2 years ago
Haleema Khan wrote in #note-4:
Thanks, Shivani!
Is it ok to pick a ticket if the others assigned are in review as there might be multiple iterations? Or do we wait until the final one?
Yes, it is ok then. :)
Updated by Haleema Khan about 2 years ago
- Status changed from In Review to Closed