Project

General

Profile

Actions

Bug #4301

closed

5.0.5 in socket mode crashes when using file-store due to uninitialized stats_ctx

Added by Jeff Lucovsky 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

When using 5.0.5 in socket mode with a config that enables file-store:

# suricata -c /suricata.yaml -v --unix-socket=/tmp/suricata.socket
11/12/2020 -- 18:19:56 - <Notice> - This is Suricata version 5.0.5 RELEASE running in SYSTEM mode
11/12/2020 -- 18:19:56 - <Info> - CPUs/cores online: 8
suricata: counters.c:1007: StatsRegisterGlobalCounter: Assertion `!(stats_ctx == ((void *)0))' failed.
Aborted (core dumped)

This diff properly initializes stats_ctx and seems to fix the issue:

diff --git a/src/suricata.c b/src/suricata.c
index 5b76b0559..dbcc123fe 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -2300,10 +2300,10 @@ static int InitSignalHandler(SCInstance *suri)
  * Will be run once per pcap in unix-socket mode */
 void PreRunInit(const int runmode)
 {
+    StatsInit();
     if (runmode == RUNMODE_UNIX_SOCKET)
         return;

-    StatsInit();
 #ifdef PROFILING
     SCProfilingRulesGlobalInit();
     SCProfilingKeywordsGlobalInit();

Related issues

Copied from Bug #4216: 5.0.5 in socket mode crashes when using file-store due to uninitialized stats_ctxClosedJason IshActions
Actions #1

Updated by Jeff Lucovsky 9 months ago

  • Copied from Bug #4216: 5.0.5 in socket mode crashes when using file-store due to uninitialized stats_ctx added
Actions #2

Updated by Jeff Lucovsky 8 months ago

  • Status changed from Assigned to In Review
Actions #4

Updated by Jeff Lucovsky 8 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF