Project

General

Profile

Actions
Copy link

Optimization #4475

closed
SB SB

Rust: Make default_port in parser registration an Option

Optimization #4475: Rust: Make default_port in parser registration an Option

Added by Shivani Bhardwaj almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shivani Bhardwaj
Target version:
7.0.0-beta1
Effort:
Difficulty:
Label:

Related issues 1 (0 open — 1 closed)

Related to Suricata - Optimization #3315: app-layer: unify registration logicClosedShivani BhardwajActions

SB Updated by Shivani Bhardwaj almost 5 years ago Actions
Copy link
 #1

SB Updated by Shivani Bhardwaj almost 5 years ago Actions
Copy link
 #2

  • Status changed from Assigned to In Review

Seems like using Option for `*const i8` is not FFI safe and Rust warns about it.
Using a null string in place of default port does seem to do the work though. Changed it in DCERPC only for now where there is not a fixed port of communication.
PR for review: https://github.com/OISF/suricata/pull/6234

SB Updated by Shivani Bhardwaj over 4 years ago Actions
Copy link
 #3

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: PDF Atom