Project

General

Profile

Actions
Copy link

Bug #454

closed
PM AS

HOME and EXT net variables

Bug #454: HOME and EXT net variables

Added by Peter Manev about 14 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Anoop Saldanha
Target version:
1.3beta2
Affected Versions:
Effort:
Difficulty:
Label:

Description

imagine the following configuration in yaml:
""
HOME_NET: "any" 

EXTERNAL_NET: "!$HOME_NET"

""

I think we should just ERR exit on that (with the latest git).
Instead Suricata loads and does not load all the rules (does not load all that use HOME_NET and EXT_NET variables in the rule, without a proper msg)

Thanks

Files

Download all files
0001-bug-454-global-check-to-see-if-address-and-port-vars.patch (6.66 KB) 0001-bug-454-global-check-to-see-if-address-and-port-vars.patch Anoop Saldanha, 05/21/2012 02:23 PM
0002-bug-454-add-unittests-for-the-address-port-conf-var-.patch (4.53 KB) 0002-bug-454-add-unittests-for-the-address-port-conf-var-.patch Anoop Saldanha, 05/21/2012 02:23 PM
0003-bug-454-rebase-fix.-Also-use-better-error-code-to-in.patch (2.19 KB) 0003-bug-454-rebase-fix.-Also-use-better-error-code-to-in.patch Anoop Saldanha, 05/21/2012 02:23 PM

AS Updated by Anoop Saldanha about 14 years ago Actions
Copy link
 #1

  • File 0001-bug-454-Provide-better-error-message-when-the-user-s.patch added
  • Status changed from New to Resolved
  • Assignee set to Anoop Saldanha

patch attached.

VJ Updated by Victor Julien about 14 years ago Actions
Copy link
 #2

Maybe it's a good idea to have a global check at start up as well. Give a fatal error if EXTERNAL_NET is !HOME_NET and HOME_NET is any.

AS Updated by Anoop Saldanha about 14 years ago Actions
Copy link
 #3

Victor Julien wrote:

Maybe it's a good idea to have a global check at start up as well. Give a fatal error if EXTERNAL_NET is !HOME_NET and HOME_NET is any.

If we are checking it shouldn't be just for HOME_NET or EXTERNAL_NET. WE will have to check every address specified in conf to see if they have a !any set amongst them.

Can do this. Np

VJ Updated by Victor Julien almost 14 years ago Actions
Copy link
 #4

  • Target version set to 1.3beta2
  • % Done changed from 0 to 80

HOME_NET and EXTERNAL_NET are the most important I think, as that is a common mistake. But testing all is cool.

Applied the per rule error, thanks.

AS Updated by Anoop Saldanha almost 14 years ago Actions
Copy link
 #5

  • File 0001-bug-454-global-check-to-see-if-address-and-port-vars.patch added

Add a global check for both addresss and port address vars.

VJ Updated by Victor Julien almost 14 years ago Actions
Copy link
 #6

Can you add some unittests as well:

port normal
port !any

address normal
address !any

The code SC_ERR_ADDRESS_ENGINE_GENERIC could be more specific I think. It's a configuration (thus user) error. Think the code should reflect that.

AS Updated by Anoop Saldanha almost 14 years ago Actions
Copy link
 #7

  • File deleted (0001-bug-454-Provide-better-error-message-when-the-user-s.patch)

AS Updated by Anoop Saldanha almost 14 years ago Actions
Copy link
 #8

  • File deleted (0001-bug-454-global-check-to-see-if-address-and-port-vars.patch)

VJ Updated by Victor Julien almost 14 years ago Actions
Copy link
 #10

  • Status changed from Resolved to Closed

All applied, thanks Anoop!

Actions
Copy link

Also available in: PDF Atom