Project

General

Profile

Actions

Optimization #5544

closed

tls keywords: increase code coverage and update documentation (if need be)

Added by Juliana Fajardini Reichow over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:
Outreachy

Description

If we look at https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-tls.c
we will notice that some keywords, such as 'subject' (https://suricata.readthedocs.io/en/latest/rules/tls-keywords.html#tls-subject) and 'issuerdn' (https://suricata.readthedocs.io/en/latest/rules/tls-keywords.html#tls-issuerdn) are not covered by our tests.

This ticket's work includes:
- Identify other tls keywords that also need coverage
- Add suricata-verify tests with rules that make use of those
- Check if we need to update our userguide documentation on those rules, and improve it accordingly

Actions #1

Updated by Juliana Fajardini Reichow over 1 year ago

  • Target version changed from TBD to 8.0.0-beta1
Actions #2

Updated by Juliana Fajardini Reichow over 1 year ago

  • Private changed from Yes to No
Actions #3

Updated by Juliana Fajardini Reichow over 1 year ago

  • Assignee changed from Community Ticket to Haleema Khan
Actions #4

Updated by Haleema Khan over 1 year ago

  • Status changed from New to In Review
Actions #5

Updated by Haleema Khan over 1 year ago

Actions #6

Updated by Juliana Fajardini Reichow about 1 year ago

Merged documentation PR: https://github.com/OISF/suricata/pull/8505

Waiting on the SV one to be merged, now.

Actions #7

Updated by Haleema Khan about 1 year ago

  • Status changed from In Review to Closed
Actions #8

Updated by Victor Julien about 1 year ago

  • Target version changed from 8.0.0-beta1 to 7.0.0-rc2
Actions

Also available in: Atom PDF