Project

General

Profile

Actions

Optimization #5544

closed
JF HK

tls keywords: increase code coverage and update documentation (if need be)

Optimization #5544: tls keywords: increase code coverage and update documentation (if need be)

Added by Juliana Fajardini Reichow over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:
Outreachy

Description

If we look at https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-tls.c
we will notice that some keywords, such as 'subject' (https://suricata.readthedocs.io/en/latest/rules/tls-keywords.html#tls-subject) and 'issuerdn' (https://suricata.readthedocs.io/en/latest/rules/tls-keywords.html#tls-issuerdn) are not covered by our tests.

This ticket's work includes:
- Identify other tls keywords that also need coverage
- Add suricata-verify tests with rules that make use of those
- Check if we need to update our userguide documentation on those rules, and improve it accordingly

JF Updated by Juliana Fajardini Reichow over 3 years ago Actions #1

  • Target version changed from TBD to 8.0.0-beta1

JF Updated by Juliana Fajardini Reichow over 3 years ago Actions #2

  • Private changed from Yes to No

JF Updated by Juliana Fajardini Reichow about 3 years ago Actions #3

  • Assignee changed from Community Ticket to Haleema Khan

HK Updated by Haleema Khan about 3 years ago Actions #4

  • Status changed from New to In Review

HK Updated by Haleema Khan about 3 years ago Actions #5

JF Updated by Juliana Fajardini Reichow about 3 years ago Actions #6

Merged documentation PR: https://github.com/OISF/suricata/pull/8505

Waiting on the SV one to be merged, now.

HK Updated by Haleema Khan about 3 years ago Actions #7

  • Status changed from In Review to Closed

VJ Updated by Victor Julien almost 3 years ago Actions #8

  • Target version changed from 8.0.0-beta1 to 7.0.0-rc2
Actions

Also available in: PDF Atom