Project

General

Profile

Actions
Copy link

Optimization #563

closed

pmq optimization -- remove patter_id_array

Added by Victor Julien over 11 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Low
Assignee:
Victor Julien
Target version:
3.1rc1
Effort:
Difficulty:
Label:

Description

pmq has 2 arrays:

1 pattern id array
2 pattern id bitarray

1st is only used in proto detect and not at detection engine runtime. We need to remove it for efficiency.

Actions
Copy link
 #1

Updated by Victor Julien over 11 years ago

  • Tracker changed from Feature to Optimization
Actions
Copy link
 #2

Updated by Anoop Saldanha over 11 years ago

the pattern_id_array is used by the proto detection to retrieve the id.

Maybe we can have some compromise between the detection phase that doesn't use the array, and the proto detection phase that needs it.

Probably pass some flag to the mpm.

Actions
Copy link
 #3

Updated by Anoop Saldanha about 11 years ago

Profiled this by removing it from ac. See no noticeable difference in perf.

I suggest we continue using this.

Actions
Copy link
 #4

Updated by Victor Julien over 10 years ago

  • Priority changed from Normal to Low
Actions
Copy link
 #5

Updated by Victor Julien about 10 years ago

  • Target version changed from 2.0rc2 to 3.0RC2
Actions
Copy link
 #6

Updated by Victor Julien over 9 years ago

  • Assignee changed from Anoop Saldanha to Victor Julien

In the new mpm code pattern_id* can be replaced by rule_id*

Actions
Copy link
 #7

Updated by Victor Julien almost 9 years ago

  • Target version changed from 3.0RC2 to 70
Actions
Copy link
 #8

Updated by Victor Julien about 8 years ago

  • Status changed from Assigned to Closed
  • Target version changed from 70 to 3.1rc1
Actions
Copy link

Also available in: Atom PDF