Project

General

Profile

Actions
Copy link

Optimization #563

closed
VJ VJ

pmq optimization -- remove patter_id_array

Optimization #563: pmq optimization -- remove patter_id_array

Added by Victor Julien over 13 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Low
Assignee:
Victor Julien
Target version:
3.1rc1
Effort:
Difficulty:
Label:

Description

pmq has 2 arrays:

1 pattern id array
2 pattern id bitarray

1st is only used in proto detect and not at detection engine runtime. We need to remove it for efficiency.

VJ Updated by Victor Julien over 13 years ago Actions
Copy link
 #1

  • Tracker changed from Feature to Optimization

AS Updated by Anoop Saldanha over 13 years ago Actions
Copy link
 #2

the pattern_id_array is used by the proto detection to retrieve the id.

Maybe we can have some compromise between the detection phase that doesn't use the array, and the proto detection phase that needs it.

Probably pass some flag to the mpm.

AS Updated by Anoop Saldanha about 13 years ago Actions
Copy link
 #3

Profiled this by removing it from ac. See no noticeable difference in perf.

I suggest we continue using this.

VJ Updated by Victor Julien over 12 years ago Actions
Copy link
 #4

  • Priority changed from Normal to Low

VJ Updated by Victor Julien about 12 years ago Actions
Copy link
 #5

  • Target version changed from 2.0rc2 to 3.0RC2

VJ Updated by Victor Julien over 11 years ago Actions
Copy link
 #6

  • Assignee changed from Anoop Saldanha to Victor Julien

In the new mpm code pattern_id* can be replaced by rule_id*

VJ Updated by Victor Julien almost 11 years ago Actions
Copy link
 #7

  • Target version changed from 3.0RC2 to 70

VJ Updated by Victor Julien about 10 years ago Actions
Copy link
 #8

  • Status changed from Assigned to Closed
  • Target version changed from 70 to 3.1rc1
Actions
Copy link

Also available in: PDF Atom