Project

General

Profile

Actions

Optimization #5801

open

filemagic keywords: increase code coverage and update documentation (if need be)

Added by Juliana Fajardini Reichow almost 2 years ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Outreachy

Description

If we look at https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-filemagic.c
we will notice that some code parts, such as the prefilter are not covered by our tests.

This ticket's work includes:
- Identifying other filemagic code portions that also need coverage
- Adding suricata-verify tests with rules that make use of those
- Checking if we need to update our userguide documentation on those keywords, and improve it accordingly

Please note that in order to test filemagic it is necessary to build Suricata with support for this feature.


Related issues 1 (0 open1 closed)

Related to Suricata - Optimization #6194: detect: modernize filename fileext filemagicClosedVictor JulienActions
Actions #1

Updated by Juliana Fajardini Reichow over 1 year ago

Actions #2

Updated by Juliana Fajardini Reichow almost 1 year ago

  • Assignee changed from Haleema Khan to Community Ticket

Hi there, according to our guidelines for stale tickets, I'm unassigning this ticket. Thanks for all your contributions, and feel free to reach out in case you have time and want to contribute to Suricata again :) :)

Refer to:
https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#stale-tickets-policy

Actions #3

Updated by Victor Julien 5 months ago

  • Target version changed from 8.0.0-beta1 to TBD
Actions

Also available in: Atom PDF