Project

General

Profile

Actions

Optimization #5801

open
JF CT

filemagic keywords: increase code coverage and update documentation (if need be)

Optimization #5801: filemagic keywords: increase code coverage and update documentation (if need be)

Added by Juliana Fajardini Reichow over 3 years ago. Updated about 10 hours ago.

Status:
Assigned
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Outreachy

Description

If we look at https://app.codecov.io/gh/OISF/suricata/blob/master/src/detect-filemagic.c
we will notice that some code parts, such as the prefilter are not covered by our tests.

This ticket's work includes:
- Identifying other filemagic code portions that also need coverage
- Adding suricata-verify tests with rules that make use of those
- Checking if we need to update our userguide documentation on those keywords, and improve it accordingly

Please note that in order to test filemagic it is necessary to build Suricata with support for this feature.


Related issues 1 (0 open1 closed)

Related to Suricata - Optimization #6194: detect: modernize filename fileext filemagicClosedVictor JulienActions

JF Updated by Juliana Fajardini Reichow almost 3 years ago Actions #1

JF Updated by Juliana Fajardini Reichow over 2 years ago Actions #2

  • Assignee changed from Haleema Khan to Community Ticket

Hi there, according to our guidelines for stale tickets, I'm unassigning this ticket. Thanks for all your contributions, and feel free to reach out in case you have time and want to contribute to Suricata again :) :)

Refer to:
https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#stale-tickets-policy

VJ Updated by Victor Julien almost 2 years ago Actions #3

  • Target version changed from 8.0.0-beta1 to TBD

OF Updated by Olusegun Fajobi 6 months ago Actions #4

  • Assignee changed from Community Ticket to Olusegun Fajobi

OF Updated by Olusegun Fajobi 6 months ago Actions #6

  • Status changed from New to In Review

PA Updated by Philippe Antoine 1 day ago Actions #10

  • Status changed from In Review to Assigned

Reputting in assigned state as PR got closed as stale

JF Updated by Juliana Fajardini Reichow about 10 hours ago Actions #11

  • Assignee changed from Olusegun Fajobi to Community Ticket

Thanks for your interest in contributing to our project, as Philippe has reported, the PR is closed as stale, so I'm un-assigning this ticket according to our stale policies.

Actions

Also available in: PDF Atom