Project

General

Profile

Actions

Task #6028

open

Task #3153: tracking: scan-build warnings

c: C11 _s style buffer handling calls

Added by Victor Julien over 2 years ago. Updated 20 days ago.

Status:
Assigned
Priority:
Low
Target version:
Effort:
Difficulty:
Label:

Description

C11 adds a suite of safe(r) buffer handle replacements for memset, memcpy, snprintf, etc. We should consider using these. This would require updates to many hundreds of call sites. Probably good to create our own wrappers, so we can instrument them to assist fuzzing as well.


Related issues 1 (1 open0 closed)

Related to Suricata - Task #6029: c: require C11AssignedJeff LucovskyActions
Actions #1

Updated by Victor Julien over 2 years ago

Actions #2

Updated by Victor Julien 10 months ago

  • Target version changed from 8.0.0-beta1 to 9.0.0-beta1
Actions #3

Updated by Victor Julien 3 months ago

  • Status changed from New to Assigned
  • Assignee changed from OISF Dev to Philippe Antoine
Actions #4

Updated by Victor Julien 3 months ago

Of course where it makes sense, we should also consider moving callers to rust.

Actions #5

Updated by Philippe Antoine 20 days ago

I wonder if the benefits of converting to memcpy_s overcome the cost (vs rustifying)

Actions #6

Updated by Philippe Antoine 20 days ago

  • Priority changed from Normal to Low

Putting this low priority until discussion

Actions #7

Updated by Victor Julien 20 days ago

I'm fine with checking if rust conversions make sense, but I'm sure not all memcpy and similar users are good candidates for immediate conversions. So it still makes sense to me to consider these new replacements for those cases.

Actions #8

Updated by Philippe Antoine 20 days ago

immediate conversions

There is nothing immediate, no PR ready...

This issue makes sense but I do not think it is high priority wrt the other tickets I have for 9...

Actions

Also available in: Atom PDF