Project

General

Profile

Actions

Task #6028

open
VJ PA

Task #3153: tracking: scan-build warnings

c: C11 _s style buffer handling calls

Task #6028: c: C11 _s style buffer handling calls

Added by Victor Julien almost 3 years ago. Updated 5 months ago.

Status:
Assigned
Priority:
Low
Target version:
Effort:
Difficulty:
Label:

Description

C11 adds a suite of safe(r) buffer handle replacements for memset, memcpy, snprintf, etc. We should consider using these. This would require updates to many hundreds of call sites. Probably good to create our own wrappers, so we can instrument them to assist fuzzing as well.


Related issues 1 (1 open0 closed)

Related to Suricata - Task #6029: c: require C11AssignedJeff LucovskyActions

VJ Updated by Victor Julien almost 3 years ago Actions #1

VJ Updated by Victor Julien about 1 year ago Actions #2

  • Target version changed from 8.0.0-beta1 to 9.0.0-beta1

VJ Updated by Victor Julien 7 months ago Actions #3

  • Status changed from New to Assigned
  • Assignee changed from OISF Dev to Philippe Antoine

VJ Updated by Victor Julien 7 months ago Actions #4

Of course where it makes sense, we should also consider moving callers to rust.

PA Updated by Philippe Antoine 5 months ago Actions #5

I wonder if the benefits of converting to memcpy_s overcome the cost (vs rustifying)

PA Updated by Philippe Antoine 5 months ago Actions #6

  • Priority changed from Normal to Low

Putting this low priority until discussion

VJ Updated by Victor Julien 5 months ago Actions #7

I'm fine with checking if rust conversions make sense, but I'm sure not all memcpy and similar users are good candidates for immediate conversions. So it still makes sense to me to consider these new replacements for those cases.

PA Updated by Philippe Antoine 5 months ago Actions #8

immediate conversions

There is nothing immediate, no PR ready...

This issue makes sense but I do not think it is high priority wrt the other tickets I have for 9...

Actions

Also available in: PDF Atom