Project

General

Profile

Actions

Feature #629

closed

Add User-Agent to filestore metdata

Added by Ludovico Cavedon almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Here is a patch to add the content of the User-Agent header to the filestore metadata:
https://github.com/cavedon/suricata/commit/06a1e9fc9fbdd198558557d851f7390271398e95

It would be great if it could be merged into future versions of suricata.

Actions #1

Updated by Victor Julien almost 9 years ago

Can you do a pull request on github for this?

Ideally we'd not loop the headers list for each of those log lines like we do now for LogFilestoreMetaGetHost and LogFilestoreMetaGetReferer.

Actions #2

Updated by Ludovico Cavedon almost 9 years ago

Victor Julien wrote:

Can you do a pull request on github for this?

Done: https://github.com/inliniac/suricata/pull/226
It actually includes also the commit for #628 as the 2 commits were done on the same branch.

Ideally we'd not loop the headers list for each of those log lines like we do now for LogFilestoreMetaGetHost and LogFilestoreMetaGetReferer.

I see, are you saying that we should not loop for each one of them, but loop once and fetch the three of them?

Thanks

Actions #3

Updated by Victor Julien almost 9 years ago

Ludovico Cavedon wrote:

Ideally we'd not loop the headers list for each of those log lines like we do now for LogFilestoreMetaGetHost and LogFilestoreMetaGetReferer.

I see, are you saying that we should not loop for each one of them, but loop once and fetch the three of them?

Right. Maybe output directly from the loop.

Although really, it would probably be better to not output while holding a flow lock, but that would involve buffering and in general more significant changes.

Actions #4

Updated by Victor Julien almost 9 years ago

  • Status changed from New to Closed
  • Assignee set to Ludovico Cavedon
  • Target version set to 1.4rc1
  • % Done changed from 0 to 100

Merged the PR, thanks. We can do the optimization later. Feel free to take that task :)

Actions

Also available in: Atom PDF