Suricata

Can you do a pull request on github for this?

Ideally we'd not loop the headers list for each of those log lines like we do now for LogFilestoreMetaGetHost and LogFilestoreMetaGetReferer.

Victor Julien wrote:

Can you do a pull request on github for this?

Done: https://github.com/inliniac/suricata/pull/226
It actually includes also the commit for #628 as the 2 commits were done on the same branch.

Ideally we'd not loop the headers list for each of those log lines like we do now for LogFilestoreMetaGetHost and LogFilestoreMetaGetReferer.

I see, are you saying that we should not loop for each one of them, but loop once and fetch the three of them?

Thanks

Ludovico Cavedon wrote:

Ideally we'd not loop the headers list for each of those log lines like we do now for LogFilestoreMetaGetHost and LogFilestoreMetaGetReferer.

I see, are you saying that we should not loop for each one of them, but loop once and fetch the three of them?

Right. Maybe output directly from the loop.

Although really, it would probably be better to not output while holding a flow lock, but that would involve buffering and in general more significant changes.