Task #6962
closedyaml: unify 0 stats counter config option terminology
Description
When doing the research for #5976 I failed to see that we also have a config stats option for the human-readable logs to output 0 counters.
Due to not seeing this before, we now have two different setting names for basically the same thing, but in different logs:zero-valued-counters
for EVE https://github.com/OISF/suricata/blob/master/suricata.yaml.in#L319 and null-values
for stats.log https://github.com/OISF/suricata/blob/master/suricata.yaml.in#L444C9-L444C20.
I think we should use the same terminology, and that I should change the recently added one to null-values
, as this one has been around for longer.
Opened a ticket so this can be registered as a lesson learned (hopefully!).
Updated by Juliana Fajardini Reichow 7 months ago
- Related to Feature #5976: eve/stats: allow hiding counters whose value is 0 added
Updated by Juliana Fajardini Reichow 7 months ago
- Status changed from New to In Review
PR for review: https://github.com/OISF/suricata/pull/10868
Updated by Juliana Fajardini Reichow 7 months ago
- Status changed from In Review to Closed
PR merged with: https://github.com/OISF/suricata/pull/10921