Project

General

Profile

Actions

Optimization #7292

closed
PA PA

CI: clang-format rechecks every main-7.0.x commit

Optimization #7292: CI: clang-format rechecks every main-7.0.x commit

Added by Philippe Antoine over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

This led to wrong formatting when fixing git conflict cf https://github.com/OISF/suricata/pull/11849


Subtasks 1 (0 open1 closed)

Bug #7293: CI: clang-format does not work for main-7.0.x branch (7.0.x backport)ClosedPhilippe AntoineActions

OT Updated by OISF Ticketbot over 1 year ago Actions #1

  • Subtask #7293 added

OT Updated by OISF Ticketbot over 1 year ago Actions #2

  • Label deleted (Needs backport to 7.0)

PA Updated by Philippe Antoine over 1 year ago Actions #3

  • Subject changed from CI: clang-format does not work for main-7.0.x branch to CI: clang-format rechecks every main-7.0.x commit

Because of FirstCommitOfBranch using master

PA Updated by Philippe Antoine over 1 year ago Actions #4

  • Tracker changed from Bug to Optimization

VJ Updated by Victor Julien about 1 year ago Actions #5

Why is this targeting 8?

PA Updated by Philippe Antoine about 1 year ago Actions #6

We need to fix it master first, otherwise, we will have the same problem when working on suricata 9 and doing backports for 8

VJ Updated by Victor Julien about 1 year ago Actions #7

  • Target version changed from 8.0.0-beta1 to 8.0.0-rc1

PA Updated by Philippe Antoine 11 months ago Actions #8

function FirstCommitOfBranch {
    local first_commit=$(git rev-list origin/master..HEAD | tail -n 1)
    echo $first_commit
}

We need to use something else than origin/master. here

PA Updated by Philippe Antoine 11 months ago Actions #9

  • Status changed from New to In Review

PA Updated by Philippe Antoine 11 months ago Actions #10

  • Status changed from In Review to Resolved

PA Updated by Philippe Antoine 11 months ago Actions #11

  • Assignee changed from OISF Dev to Philippe Antoine

PA Updated by Philippe Antoine 11 months ago Actions #12

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom