Project

General

Profile

Actions

Optimization #7292

closed

CI: clang-format rechecks every main-7.0.x commit

Added by Philippe Antoine 8 months ago. Updated 21 days ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

This led to wrong formatting when fixing git conflict cf https://github.com/OISF/suricata/pull/11849


Subtasks 1 (0 open1 closed)

Bug #7293: CI: clang-format does not work for main-7.0.x branch (7.0.x backport)ClosedPhilippe AntoineActions
Actions #1

Updated by OISF Ticketbot 8 months ago

  • Subtask #7293 added
Actions #2

Updated by OISF Ticketbot 8 months ago

  • Label deleted (Needs backport to 7.0)
Actions #3

Updated by Philippe Antoine 8 months ago

  • Subject changed from CI: clang-format does not work for main-7.0.x branch to CI: clang-format rechecks every main-7.0.x commit

Because of FirstCommitOfBranch using master

Actions #4

Updated by Philippe Antoine 8 months ago

  • Tracker changed from Bug to Optimization
Actions #5

Updated by Victor Julien 5 months ago

Why is this targeting 8?

Actions #6

Updated by Philippe Antoine 5 months ago

We need to fix it master first, otherwise, we will have the same problem when working on suricata 9 and doing backports for 8

Actions #7

Updated by Victor Julien 4 months ago

  • Target version changed from 8.0.0-beta1 to 8.0.0-rc1
Actions #8

Updated by Philippe Antoine about 1 month ago

function FirstCommitOfBranch {
    local first_commit=$(git rev-list origin/master..HEAD | tail -n 1)
    echo $first_commit
}

We need to use something else than origin/master. here

Actions #9

Updated by Philippe Antoine 24 days ago

  • Status changed from New to In Review
Actions #10

Updated by Philippe Antoine 22 days ago

  • Status changed from In Review to Resolved
Actions #11

Updated by Philippe Antoine 22 days ago

  • Assignee changed from OISF Dev to Philippe Antoine
Actions #12

Updated by Philippe Antoine 21 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF