Project

General

Profile

Actions
Copy link

Optimization #7474

closed

Pcap file mode locking on time synchronization

Added by Eric Leblond 19 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Leblond
Target version:
TBD
Effort:
Difficulty:
Label:

Description

When reading a pcap file, we have a contention point on TmThreadsSetThreadTimestamp():

Lock                                               Cnt        Avg ticks Max ticks    Total ticks  Cont    Func
------------------                                 ---------- --------- ------------ ------------ ------- ---------
(mtx) tm-threads.c:2190                            1049627    1193      17819166     1253023306   21777   TmThreadsSetThreadTimestamp
(mtx) flow-hash.c:875                              48945      527       582920       25825014     0       FlowGetFlowFromHash
(mtx) flow-spare-pool.c:175                        8          540       1056         4320         0       FlowSpareGetFromPool
(mtx) flow-hash.c:752                              729        977       4816         712754       0       FlowGetNew
(mtx) util-pool-thread.c:181                       760        1401      21486        1065246      0       PoolThreadGetById
(mtx) flow-hash.c:922                              48216      401       435596       19352498     0       FlowGetFlowFromHash
(mtx) util-logopenfile.c:187                       1252       8774      1969800      10986230     36      OutputWriteLock

This is a simple time set but it lock threads as the API make it possible to update other threads, even if it is not used.

Actions
Copy link

Also available in: Atom PDF