Project

General

Profile

Actions
Copy link

Task #7738

open
PC PC

ldap: update ldap-parser crate to 0.5.0 and refactor code

Task #7738: ldap: update ldap-parser crate to 0.5.0 and refactor code

Added by Pierre Chifflier 10 months ago. Updated 10 months ago.

Status:
Assigned
Priority:
Normal
Assignee:
Pierre Chifflier
Target version:
9.0.0-beta1
Effort:
Difficulty:
Label:

Description

The current version of ldap-parser is 0.5.0, so the dependency in Suricata should be upgraded.
Version 0.5.0 also has support for the ToStatic trait, which can be used to refactor code and simplify/eliminate all redundant code in Suricata's LDAP parser (currently, all types are duplicated from the Rust crate).
I have already worked on this and have a PR ready.

Note: this will bump the dependency on asn1-rs as well, but it keeps compatibility with old rust compilers (MSRV is 1.63). After that, we can also upgrade other ASN.1-based parsers as well.

VJ Updated by Victor Julien 10 months ago Actions
Copy link
 #1

@Pierre Chifflier just a FYI, if you want this to go into 8 you have just a few days left. Otherwise we'll target 9.

VJ Updated by Victor Julien 10 months ago Actions
Copy link
 #2

  • Subject changed from Update ldap-parser to 0.5.0 and refactor code to ldap: update ldap-parser crate to 0.5.0 and refactor code

PC Updated by Pierre Chifflier 10 months ago Actions
Copy link
 #3

Victor Julien wrote in #note-1:

@Pierre Chifflier just a FYI, if you want this to go into 8 you have just a few days left. Otherwise we'll target 9.

Hi Victor,
I think it's safer to target 9, I do not feel comfortable changing this just before release (since it can also mean updating x509-parser, kerberos-parser etc. to have only one dependency on asn1-rs)

VJ Updated by Victor Julien 10 months ago Actions
Copy link
 #4

  • Status changed from New to Assigned
  • Target version changed from TBD to 9.0.0-beta1
Actions
Copy link

Also available in: PDF Atom