Bug #8271: pfring: StringParseUnt16 function is not found - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #8271

open

pfring: StringParseUnt16 function is not found

Added by Aditya Nugraha 6 days ago. Updated about 23 hours ago.

Status:

In Review

Priority:

Normal

Assignee:

Jason Ish

Target version:

9.0.0-beta1

Affected Versions:

8.0.3, git main

Effort:

Difficulty:

Label:

Description

Perhaps developer is forgot to update src/util-byte.c & src/util-byte.h

runmode-pfring.c: In function 'OldParsePfringConfig':
runmode-pfring.c:118:17: error: implicit declaration of function 'StringParseUnt16'; did you mean 'StringParseInt16'? [-Wimplicit-function-declaration]
  118 |             if (StringParseUnt16(&pfconf->threads, 10, 0, threadsstr) < 0) {
      |                 ^~~~~~~~~~~~~~~~
      |                 StringParseInt16

Subtasks 1 (1 open — 0 closed)

Actions

Copy link

Updated by Jason Ish 2 days ago

Both git main and 8.0 have StringParseUint16. Do you happen to have older Suricata C header files installed in some other location, like "/usr/include", or "/usr/local/include"?

Actions

Copy link

Updated by Aditya Nugraha 1 day ago

Jason Ish wrote in #note-1:

Both git main and 8.0 have StringParseUint16. Do you happen to have older Suricata C header files installed in some other location, like "/usr/include", or "/usr/local/include"?

I think it's a typo in plugins/pfring/runmode-pfring.c line 118, instead of StringParseUnt16, which should be StringParseUint16 ?.

Actions

Copy link

Updated by Jason Ish 1 day ago

Status changed from New to Assigned
Assignee set to Jason Ish
Target version changed from TBD to 9.0.0-beta1
Affected Versions 8.0.3 added
Label Needs backport to 8.0 added

I see it now. Odd, our CI job for this plugin passes, but I think it might be due to some loose linking rules for plugins, needs investigation, as its just a compile warning and not an error:

runmode-pfring.c:118:17: warning: implicit declaration of function 'StringParseUnt16'; did you mean 'StringParseInt16'? [-Wimplicit-function-declaration]
831

Actions

Copy link