Project

General

Profile

Actions
Copy link

Bug #8271

closed
AN JI

pfring: StringParseUnt16 function is not found

Bug #8271: pfring: StringParseUnt16 function is not found

Added by Aditya Nugraha about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Jason Ish
Target version:
9.0.0-beta1
Affected Versions:
8.0.3, git main
Effort:
Difficulty:
Label:

Description

Perhaps developer is forgot to update src/util-byte.c & src/util-byte.h

runmode-pfring.c: In function 'OldParsePfringConfig':
runmode-pfring.c:118:17: error: implicit declaration of function 'StringParseUnt16'; did you mean 'StringParseInt16'? [-Wimplicit-function-declaration]
  118 |             if (StringParseUnt16(&pfconf->threads, 10, 0, threadsstr) < 0) {
      |                 ^~~~~~~~~~~~~~~~
      |                 StringParseInt16

Subtasks 1 (0 open — 1 closed)

Bug #8284: pfring: StringParseUnt16 function is not found (8.0.x backport)RejectedJason IshActions

JI Updated by Jason Ish about 2 months ago Actions
Copy link
 #1

Both git main and 8.0 have StringParseUint16. Do you happen to have older Suricata C header files installed in some other location, like "/usr/include", or "/usr/local/include"?

AN Updated by Aditya Nugraha about 2 months ago Actions
Copy link
 #2

Jason Ish wrote in #note-1:

Both git main and 8.0 have StringParseUint16. Do you happen to have older Suricata C header files installed in some other location, like "/usr/include", or "/usr/local/include"?

I think it's a typo in plugins/pfring/runmode-pfring.c line 118, instead of StringParseUnt16, which should be StringParseUint16 ?.

JI Updated by Jason Ish about 2 months ago Actions
Copy link
 #3

  • Status changed from New to Assigned
  • Assignee set to Jason Ish
  • Target version changed from TBD to 9.0.0-beta1
  • Affected Versions 8.0.3 added
  • Label Needs backport to 8.0 added

I see it now. Odd, our CI job for this plugin passes, but I think it might be due to some loose linking rules for plugins, needs investigation, as its just a compile warning and not an error:

runmode-pfring.c:118:17: warning: implicit declaration of function 'StringParseUnt16'; did you mean 'StringParseInt16'? [-Wimplicit-function-declaration]
831

OT Updated by OISF Ticketbot about 2 months ago Actions
Copy link
 #4

  • Subtask #8284 added

OT Updated by OISF Ticketbot about 2 months ago Actions
Copy link
 #5

  • Label deleted (Needs backport to 8.0)

JI Updated by Jason Ish about 2 months ago Actions
Copy link
 #6

  • Subject changed from StringParseUnt16 function is not found to pfring: StringParseUnt16 function is not found

JI Updated by Jason Ish about 2 months ago Actions
Copy link
 #7

  • Status changed from Assigned to In Review

JI Updated by Jason Ish about 1 month ago Actions
Copy link
 #8

  • Status changed from In Review to Resolved

JI Updated by Jason Ish about 1 month ago Actions
Copy link
 #9

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: PDF Atom