Bug #8473
openBypassManager checks registration of BypassedCheckFuncInit instead of BypassedCheckFunc
Description
At the initialization stage, BypassManager should check whether any BypassedCheckFunc has been registered.
Instead, BM calls BypassedCheckFuncInit, then checks again whether it has been registered.
I propose checking whether any BypassedCheckFunc has been registered, rather than BypassedCheckFuncInit.
OT Updated by OISF Ticketbot 29 days ago
- Subtask #8474 added
OT Updated by OISF Ticketbot 29 days ago
- Label deleted (
Needs backport to 8.0)
OT Updated by OISF Ticketbot 29 days ago
- Subtask #8475 added
OT Updated by OISF Ticketbot 29 days ago
- Label deleted (
Needs backport to 7.0)
PA Updated by Philippe Antoine 22 days ago
Is this rather an optimization than a bug ?
Does it deserve a backport to 7 ?
AK Updated by Adam Kiripolsky 21 days ago
In my opinion, it is a bug, as the original behavior does not make sense (using the BypassedCheckFuncInit function and checking only after that whether it exists).
PA Updated by Philippe Antoine 20 days ago
Adam Kiripolsky wrote in #note-6:
In my opinion, it is a bug, as the original behavior does not make sense (using the BypassedCheckFuncInit function and checking only after that whether it exists).
So, can we get a call of a NULL-pointer callback in the current situation ? How can this happen ?
I see something that looks correct in the current code
if (bypassedfunclist[i].FuncInit) {
bypassedfunclist[i].FuncInit(th_v, &curtime, bypassedfunclist[i].data);
}