Actions
Optimization #8500
open
SP
reputation: remove useless dangerous code
Optimization #8500:
reputation: remove useless dangerous code
Effort:
Difficulty:
Label:
Description
in src/reputation.c there is 2 places where:
while (isspace((unsigned char)line[--len]));
immediately followed by
len = strlen(line);
this while() is useless and dungerous, because it can lead to access memory before the buffer
if line contains all whitespace characters and the first one is not '\n'/'\r'/'\t' or ' ' (i.e. 0x0c)
SP Updated by Sergey Pinaev 1 day ago
Actions