Actions
Bug #860
closed1.4.3: src/source-pcap-file.c has typo for uint8_t and uint16_t on line 53
Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Affected Versions:
Effort:
Difficulty:
Label:
Description
Solaris Sun Studio compiler didn't like line 53:
"source-pcap-file.c", line 53: syntax error before or at: u_int8_t "source-pcap-file.c", line 53: warning: undefined or missing type for: u_int8_t "source-pcap-file.c", line 53: syntax error before or at: PacketQueue "source-pcap-file.c", line 53: warning: undefined or missing type for: PacketQueue "source-pcap-file.c", line 120: warning: implicit function declaration: __builtin_expect </PRE> I'm not sure how that got passed by any compiler, u_int8_t and u_int16_t don't exist, on Solaris anyway. Diff is here: <pre> --- suricata-1.4.3/src/source-pcap-file.c.orig Mon Jul 8 11:56:59 2013 +++ suricata-1.4.3/src/source-pcap-file.c Mon Jul 8 11:57:10 2013 @@ -50,7 +50,7 @@ typedef struct PcapFileGlobalVars_ { pcap_t *pcap_handle; - void (*Decoder)(ThreadVars *, DecodeThreadVars *, Packet *, u_int8_t *, u_int16_t, PacketQueue *); + void (*Decoder)(ThreadVars *, DecodeThreadVars *, Packet *, uint8_t *, uint16_t, PacketQueue *); int datalink; struct bpf_program filter; uint64_t cnt; /** packet counter */ </pre>
Updated by Mark Solaris almost 11 years ago
Who wrote this redmine crap anyway? case sensitive html? Lol. Can't edit? Duh.
Actions