Project

General

Profile

Actions
Copy link

Task #8631

open
JI OD

lib: stream-tcp-private.h is not actually private

Task #8631: lib: stream-tcp-private.h is not actually private

Added by Jason Ish 10 days ago. Updated 10 days ago.

Status:
Triaged
Priority:
Normal
Assignee:
OISF Dev
Target version:
TBD
Effort:
Difficulty:
Label:

Description

Reference: https://forum.suricata.io/t/update-on-icap-integration-proposal-working-implementation-of-sslproxy-icap-branch-icapsuricata-libsuricata-service/6357/5

stream-tcp-private.h is intended to be private, but is included by many non-private headers. The better workflow for private headers is that only ".c" files include them, and the private headers include the public headers needed, or the ".c" source file includes all the headers required. This prevents private headers from being needed in public headers.

Actions
Copy link

Also available in: PDF Atom