Project

General

Profile

Actions

Bug #864

closed

Optimization #832: clean up packet action macros

backport packet action macro's

Added by Victor Julien almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Currently we have an issue where in detect-engine-alert.c we set PASS on the 'root' pkt, but check it on the tunneled (fake) packet. This leads to FP as reported on oisf-users.

Instead of fixing what we have, lets backport the packet action macro's from master, as master doesn't have this problem because it uses the TEST macro.

Actions #2

Updated by Eric Leblond almost 11 years ago

  • % Done changed from 0 to 80
Actions #3

Updated by Victor Julien almost 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 80 to 100

Merged, thanks Eric!

Confirmed that the pass bug is gone.

Actions

Also available in: Atom PDF