Project

General

Profile

Actions

Optimization #8673

open
PA OD

detect/firewall: DoParseAppPolicy has logical dead code if (hookname == NULL)

Optimization #8673: detect/firewall: DoParseAppPolicy has logical dead code if (hookname == NULL)

Added by Philippe Antoine about 20 hours ago.

Status:
New
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:

Description

From coverity CID 1694489

The second

        if (hookname == NULL)
            return 0;

is dead code because we had previously already the same

        if (hookname == NULL)
            return 0;

that would have returned from the function.

Can we just remove the dead code ? Or should we not return in the first place as there is still some work to do ?

No data to display

Actions

Also available in: PDF Atom