Bug #881
closed
Added by Victor Julien almost 11 years ago.
Updated almost 11 years ago.
Description
https://buildbot.suricata-ids.org/builders/pcap%20openbsd-5.2/builds/131/steps/shell_5/logs/stdio
checking iconv.h usability... yes
checking iconv.h presence... yes
checking for iconv.h... yes
checking for libiconv_close in -liconv... yes
/bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I.. -O2 -D_GNU_SOURCE -g -Wall -Wextra -std=gnu99 -pedantic -Wextra -Wno-missing-field-initializers -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wno-unused-parameter -O2 -Wstrict-overflow=1 -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -MT htp_config.lo -MD -MP -MF .deps/htp_config.Tpo -c -o htp_config.lo htp_config.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -O2 -D_GNU_SOURCE -g -Wall -Wextra -std=gnu99 -pedantic -Wextra -Wno-missing-field-initializers -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wno-unused-parameter -O2 -Wstrict-overflow=1 -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -MT htp_config.lo -MD -MP -MF .deps/htp_config.Tpo -c htp_config.c -fPIC -DPIC -o .libs/htp_config.o
In file included from htp_config.c:39:
htp_private.h:54:19: error: iconv.h: No such file or directory
Odd that it appears that iconv.h does exist, but libhtp doesn't find it.
- Status changed from New to Assigned
- Assignee changed from OISF Dev to Victor Julien
I can reproduce this in my local vm.
Can reproduce it in just the libhtp checkout as well, looks like a libhtp issue.
- Status changed from Assigned to New
- Assignee changed from Victor Julien to OISF Dev
LDFLAGS="-L/usr/local/lib/" CPPFLAGS="-I/usr/local/include/" ./configure
Makes the libhtp build succeed.
With it, configure gives:
checking for iconv declaration...
extern size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);
W/o it, it gives:
checking for iconv... no, consider installing GNU libiconv
The option --with-libiconv-prefix has no effect.
Looks like patching configure.ac to know about OpenBSD does the trick:
diff --git a/configure.ac b/configure.ac
index ffbf3e5..cb51ca9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -122,6 +122,12 @@ case "$OS" in
CPPFLAGS="${CPPFLAGS} -I/usr/local/include"
LDFLAGS="${LDFLAGS} -L/usr/local/lib"
;;
+ OpenBSD*)
+ AC_MSG_RESULT(OpenBSD)
+ OS_OPENBSD="true"
+ CPPFLAGS="${CPPFLAGS} -I/usr/local/include"
+ LDFLAGS="${LDFLAGS} -L/usr/local/lib"
+ ;;
Linux*)
AC_MSG_RESULT(Linux)
OS_LINUX="true"
- Subject changed from OpenBSD build broken to OpenBSD buildbot broken
- Status changed from New to Assigned
- Assignee changed from OISF Dev to Victor Julien
- Priority changed from Normal to Low
- Target version changed from 2.0beta1 to 2.0beta2
Build is not completely broken. It works with the line above:
LDFLAGS="-L/usr/local/lib/" CPPFLAGS="-I/usr/local/include/" ./configure
So not a release critical issue.
- Status changed from Assigned to Closed
- Target version changed from 2.0beta2 to 2.0beta1
- % Done changed from 0 to 100
PR merged in time for beta1. Buildbot is happy.
Also available in: Atom
PDF