Bug #1768
closedpacket processing threads doubled
Description
Using workers mode with both afpacket or pfring with - 3.1dev (rev faf84fe).
If an interface(the only one) is configured with 8 threads in suricata.yaml's afpacket section - example eth2 - when starting Suricata like so:
/usr/local/bin/suricata -c /etc/suricata/suricata.yaml --af-packet=eth2
we get 8 packet processing threads.
If we start suricata like so:
/usr/local/bin/suricata -c /etc/suricata/suricata.yaml --af-packet
we get 16 packet processing threads. This can be observed with pfring as well.
Updated by Andreas Herz almost 8 years ago
For now we narrowed it down to the fact, that there are two calls of "ParseInterfacesList" that came with https://github.com/inliniac/suricata/commit/c0294521dd3124bd0795bdb009f6eef1892017d1 so if I remove that line it's the correct amount of threads again.
Updated by Victor Julien almost 8 years ago
- Status changed from New to Assigned
- Assignee set to Andreas Herz
- Target version set to 70
Updated by Victor Julien almost 8 years ago
- Priority changed from Normal to High
Updated by Andreas Herz almost 8 years ago
Victor, do you remember why you copied it down there?
I see several solutions to resolve that, depending on what you head in mind :)
1. Remove that second call
2. Check if it has been already finished
3. Call it twice but fix it within the call
Updated by Victor Julien almost 8 years ago
I don't think I had anything in mind specifically. It's done a 'cleanup' commit, so likely just an oversight.
Updated by Victor Julien almost 8 years ago
- Status changed from Assigned to Closed
- Target version changed from 70 to 3.1rc1