Project

General

Profile

Bug #2851

suricata-update doesn't properly load some sections in update.yaml file

Added by Srinath M. 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Affected Versions:
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

I'm setting the following in the update.yaml file

ignore:
  - "*deleted.rules" 
  - "*pop3.rules" 

I get the loading message:

26/2/2019 -- 13:46:04 - <Debug> -- This is suricata-update version 1.0.3 (rev: None); Python: 2.7.15rc1 (default, Nov 12 2018, 14:31:15) - [GCC 7.3.0]
26/2/2019 -- 13:46:04 - <Info> -- Loading /opt/suricata/etc/suricata/update.yaml

But the files do not get ignored. It seems that the code loading command line parameters override previous settings even when no parameters are given.
The problem seems to be that the default for the --ignore flag is "[]" and not "None"

Changing line 182 in config.py file seems to solve the issue.

From:

        elif getattr(args, arg) is not None:

To:

        elif getattr(args, arg) not in [ None, [] ]:

History

#1

Updated by Shivani Bhardwaj 2 months ago

  • Assignee deleted (Jason Ish)
#2

Updated by Shivani Bhardwaj 2 months ago

  • Label Beginner, Outreachy added
#3

Updated by Shivani Bhardwaj 2 months ago

  • Status changed from New to Assigned
  • Assignee set to Victor Julien
#4

Updated by Shivani Bhardwaj 2 months ago

  • Assignee deleted (Victor Julien)
#5

Updated by Shivani Bhardwaj about 2 months ago

  • Status changed from Assigned to Closed
  • Target version set to 1.0.5

Also available in: Atom PDF