Project

General

Profile

Bug #2869

Failure with --no-merge

Added by Leif Tishendorf 16 days ago. Updated 12 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Target version:
Affected Versions:
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

Running into an issue when I run 'suricata-update --no-merge'.

suricata-update -v --no-merge
8/3/2019 -- 10:00:13 - <Debug> -- This is suricata-update version 1.0.4 (rev: b883d2f); Python: 2.7.15rc1 (default, Nov 12 2018, 14:31:15) - [GCC 7.3.0]
8/3/2019 -- 10:00:13 - <Info> -- Loading /etc/suricata/update.yaml
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value force -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value verbose -> True
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value enable -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value no-merge -> True
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value version -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value dump-sample-configs -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value no-test -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value subcommand -> update
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value modify -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value no-reload -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value no-ignore -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value disable -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value etopen -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value now -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value url -> []
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value drop -> False
8/3/2019 -- 10:00:13 - <Debug> -- Setting configuration value ignore -> []
8/3/2019 -- 10:00:13 - <Debug> -- Looking for suricata in /root/.cargo/bin
8/3/2019 -- 10:00:13 - <Debug> -- Looking for suricata in /usr/local/sbin
8/3/2019 -- 10:00:13 - <Debug> -- Looking for suricata in /usr/local/bin
8/3/2019 -- 10:00:13 - <Debug> -- Looking for suricata in /usr/sbin
8/3/2019 -- 10:00:13 - <Debug> -- Looking for suricata in /usr/bin
8/3/2019 -- 10:00:13 - <Debug> -- Found /usr/bin/suricata.
8/3/2019 -- 10:00:13 - <Info> -- Using data-directory /var/lib/suricata.
8/3/2019 -- 10:00:13 - <Info> -- Using Suricata configuration /etc/suricata/suricata.yaml
8/3/2019 -- 10:00:13 - <Info> -- Using /etc/suricata/rules for Suricata provided rules.
8/3/2019 -- 10:00:13 - <Info> -- Found Suricata version 4.1.3 at /usr/bin/suricata.
8/3/2019 -- 10:00:13 - <Info> -- Loading /etc/suricata/suricata.yaml
8/3/2019 -- 10:00:13 - <Info> -- Disabling rules with proto modbus
8/3/2019 -- 10:00:13 - <Info> -- Disabling rules with proto enip
8/3/2019 -- 10:00:13 - <Info> -- Disabling rules with proto dnp3
8/3/2019 -- 10:00:13 - <Debug> -- Resolved source et/pro to URL https://rules.emergingthreatspro.com/<secret-code>/suricata-4.1.3/etpro.rules.tar.gz.
8/3/2019 -- 10:00:13 - <Info> -- Checking https://rules.emergingthreatspro.com/<secret-code>/suricata-4.1.3/etpro.rules.tar.gz.md5.
8/3/2019 -- 10:00:13 - <Debug> -- Setting HTTP User-Agent to Suricata-Update/1.0.4 (OS: Linux; CPU: x86_64; Python: 2.7.15rc1; Dist: Ubuntu/18.04; Suricata: 4.1.3)
8/3/2019 -- 10:00:14 - <Debug> -- Local checksum=|6e2a00095e5ed06f5d9821f3dcd8093d|; remote checksum=|6e2a00095e5ed06f5d9821f3dcd8093d|
8/3/2019 -- 10:00:14 - <Info> -- Remote checksum has not changed. Not fetching.
8/3/2019 -- 10:00:15 - <Info> -- Loading local file /etc/suricata/rules/local.rules
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/shellcode.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/imap.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/mobile_malware.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/attack_response.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/pop3.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/inappropriate.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/telnet.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/tor.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/scada_special.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/scan.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/icmp_info.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/web_client.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/icmp.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/exploit.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/tftp.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/user_agents.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/snmp.rules.
8/3/2019 -- 10:00:15 - <Debug> -- Parsing rules/current_events.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/scada.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/dshield.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/web_server.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/dos.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/activex.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/sql.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/botcc.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/compromised.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/games.rules.
8/3/2019 -- 10:00:16 - <Debug> -- Parsing rules/deleted.rules.
8/3/2019 -- 10:00:17 - <Debug> -- Parsing rules/trojan.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/netbios.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/rpc.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/ftp.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/drop.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/voip.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing /etc/suricata/rules/local.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/dns.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/worm.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/policy.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/chat.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/p2p.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/misc.rules.
8/3/2019 -- 10:00:19 - <Debug> -- Parsing rules/web_specific_apps.rules.
8/3/2019 -- 10:00:20 - <Debug> -- Parsing rules/botcc.portgrouped.rules.
8/3/2019 -- 10:00:20 - <Debug> -- Parsing rules/malware.rules.
8/3/2019 -- 10:00:20 - <Debug> -- Parsing rules/ciarmy.rules.
8/3/2019 -- 10:00:20 - <Debug> -- Parsing rules/info.rules.
8/3/2019 -- 10:00:20 - <Debug> -- Parsing rules/smtp.rules.
8/3/2019 -- 10:00:20 - <Info> -- Loaded 56990 rules.
8/3/2019 -- 10:00:21 - <Info> -- Disabled 0 rules.
8/3/2019 -- 10:00:21 - <Info> -- Enabled 0 rules.
8/3/2019 -- 10:00:21 - <Info> -- Modified 0 rules.
8/3/2019 -- 10:00:21 - <Info> -- Dropped 0 rules.
8/3/2019 -- 10:00:21 - <Debug> -- Found 448 required flowbits.
8/3/2019 -- 10:00:21 - <Debug> -- Found 283 rules to enable to for flowbit requirements
8/3/2019 -- 10:00:21 - <Debug> -- Found 450 required flowbits.
8/3/2019 -- 10:00:21 - <Debug> -- Found 1 rules to enable to for flowbit requirements
8/3/2019 -- 10:00:21 - <Debug> -- Found 450 required flowbits.
8/3/2019 -- 10:00:21 - <Debug> -- Found 0 rules to enable to for flowbit requirements
8/3/2019 -- 10:00:21 - <Debug> -- All required rules enabled.
8/3/2019 -- 10:00:21 - <Info> -- Enabled 284 rules for flowbit dependencies.
8/3/2019 -- 10:00:21 - <Info> -- Backing up current rules.
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/shellcode.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/imap.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/mobile_malware.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/attack_response.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/pop3.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/inappropriate.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/telnet.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/tor.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/scada_special.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/scan.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/icmp_info.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/ETPRO-License.txt
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/web_client.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/icmp.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/exploit.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/tftp.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/user_agents.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/snmp.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/current_events.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/scada.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/dshield.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/compromised-ips.txt
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/web_server.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/dos.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/activex.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/gpl-2.0.txt
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/sql.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/botcc.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/compromised.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/LICENSE
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/suricata-4.0-enhanced-etpro.txt
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/games.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/deleted.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/trojan.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/netbios.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/rpc.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/sid-msg.map
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/ftp.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/drop.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/voip.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/classification.config
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/local.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/dns.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/worm.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/policy.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/chat.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/p2p.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/misc.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/web_specific_apps.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/botcc.portgrouped.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/malware.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/ciarmy.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/info.rules
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/BSD-License.txt
8/3/2019 -- 10:00:21 - <Debug> -- Recording new file /var/lib/suricata/rules/smtp.rules
Traceback (most recent call last):
  File "/usr/local/bin/suricata-update", line 33, in <module>
    sys.exit(main.main())
  File "/usr/local/lib/python2.7/dist-packages/suricata/update/main.py", line 1458, in main
    sys.exit(_main())
  File "/usr/local/lib/python2.7/dist-packages/suricata/update/main.py", line 1407, in _main
    write_to_directory(config.get_output_dir(), files, rulemap)
  File "/usr/local/lib/python2.7/dist-packages/suricata/update/main.py", line 629, in write_to_directory
    added.append(rule.id)
UnboundLocalError: local variable 'rule' referenced before assignment

History

#1

Updated by VAGISHA GUPTA 13 days ago

Hello I am an outreachy applicant. I have fixed this issue locally. I am sending a PR shortly.

#2

Updated by VAGISHA GUPTA 13 days ago

VAGISHA GUPTA wrote:

Hello I am an outreachy applicant. I have fixed this issue locally. I am sending a PR shortly.

Here is the PR
https://github.com/OISF/suricata-update/pull/102

#3

Updated by Shivani Bhardwaj 12 days ago

  • Status changed from New to Feedback
#4

Updated by Shivani Bhardwaj 12 days ago

  • Target version set to Soon
  • Effort set to low
  • Difficulty set to low
  • Label Beginner, Outreachy added
#5

Updated by Shivani Bhardwaj 12 days ago

  • Assignee deleted (Jason Ish)

Also available in: Atom PDF