Project

General

Profile

Actions

Task #2924

closed

suricata-verify: per check version conditions

Added by Victor Julien over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Allow 'version' and 'min-version' to be specified per check in addition to the current per test.

Goal is to allow for a single test that tests different output behaviour for different Suricata versions.

Example:

checks:
  - filter:
      version: 4.1.0
      count: 1
      match:
        event_type: tls
        tls.sni: "localhost" 
  - filter:
      min-version: 5.0.0
      count: 1
      match:
        event_type: tls
        tls.new_sni: "localhost" 

Reference: https://github.com/OISF/suricata/pull/3645

Actions #1

Updated by Shivani Bhardwaj over 2 years ago

How are we dealing with the paths of multiple versions of Suricata? Currently, we do a version check before starting the tests for ./src/suricata in the current directory only and use the same instance to run the tests. What should be the assumption for paths of these different versioned Suricata instances?

Apologies for the misunderstanding on my end.

Actions #2

Updated by Shivani Bhardwaj over 2 years ago

  • Status changed from Assigned to Feedback
Actions #3

Updated by Victor Julien over 2 years ago

  • Status changed from Feedback to Closed
  • Priority changed from High to Normal
  • Target version changed from 70 to QA
Actions

Also available in: Atom PDF