Suricata

Would something like this be acceptable as a fix in util-thash.c:

@ -230,6 +230,15 @@ static void THashInitConfig(THashTableContext *ctx, const char *cnf_prefix)
     GET_VAR(cnf_prefix, "hash-size");
     if ((ConfGet(varname, &conf_val)) == 1)
     {
+        int varlen = strlen(conf_val);
+        for (int i=0; i<varlen; i++)
+          if (!isdigit(conf_val[i]))
+          {
+            SCLogError(SC_ERR_SIZE_PARSE, "Error parsing %s in %s" 
+                       "from conf file - %s. Killing engine",
+                       varname, cnf_prefix, conf_val);
+            exit(EXIT_FAILURE);
+          }

with a suricata.yaml hash-size value of 256mb we now see:
35360] 16/10/2019 -- 16:23:23 - (datasets.c:417) <Notice> (DatasetGet) -- dataset and datarep features are experimental and subject to change
[35360] 16/10/2019 -- 16:23:23 - (util-thash.c:237) <Error> (THashInitConfig) -- [ERRCODE: SC_ERR_SIZE_PARSE(198)] - Error parsing datasets.dns-ioc.hash.hash-size in datasets.dns-ioc.hashfrom conf file - 256mb. Killing engine

if the value is just a number the yaml appears to be parsed properly and the dataset initialized as expected.

Hi Andreas!

I did end up sending a PR, in discussions on GH it looks related maybe to something Shivani is working on with atoi updates. Work she is doing there may apply/address this issue as well. Perhaps, if it can wait we can discuss more at Suricon?