Project

General

Profile

Actions

Bug #3526

closed

5.0.x Kerberos vulnerable to TCP splitting evasion

Added by Philippe Antoine over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Problem happens if the split happens in the middle of a record size
Another problems happens if the buffer size is less than 4

Problem found while running suricata-verify tests against Suricata compiled with this patch

diff --git a/src/app-layer.c b/src/app-layer.c
index b614f2712..0149d6b4f 100644
--- a/src/app-layer.c
+++ b/src/app-layer.c
@@ -658,8 +658,15 @@ int AppLayerHandleTCPData(ThreadVars *tv, TcpReassemblyThreadCtx *ra_ctx,
          * a start msg should have gotten us one */
         if (f->alproto != ALPROTO_UNKNOWN) {
             PACKET_PROFILING_APP_START(app_tctx, f->alproto);
+#ifndef LOLSPLIT
+            for (size_t i = 0; i < data_len; i++) {
+                r = AppLayerParserParse(tv, app_tctx->alp_tctx, f, f->alproto,
+                                        flags, data+i, 1);
+            }
+#else
             r = AppLayerParserParse(tv, app_tctx->alp_tctx, f, f->alproto,
                                     flags, data, data_len);
+#endif
             PACKET_PROFILING_APP_END(app_tctx, f->alproto);
             if (r >= 0) {
                 (*stream)->app_progress_rel += data_len;

Related issues

Copied from Bug #3525: Kerberos vulnerable to TCP splitting evasionClosedPhilippe AntoineActions
Copied to Bug #3527: 4.1.x Kerberos vulnerable to TCP splitting evasionClosedShivani BhardwajActions
Actions #1

Updated by Philippe Antoine over 1 year ago

  • Copied from Bug #3525: Kerberos vulnerable to TCP splitting evasion added
Actions #2

Updated by Philippe Antoine over 1 year ago

  • Copied to Bug #3527: 4.1.x Kerberos vulnerable to TCP splitting evasion added
Actions #3

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from New to Assigned
  • Assignee set to Jeff Lucovsky
Actions #4

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from Assigned to In Review
Actions #5

Updated by Jeff Lucovsky over 1 year ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF