Documentation #3727
closedbyte_extract documentation is missing some optional arguments
Description
The byte_extract documentation is missing some optional args such as litte, big, multiplier, etc
This is on the master branch, but technically impacts all versions that support these optional args. These args have existed for many years already. git blame shows the changes as 6+ years old.
Current doc mentions:
https://github.com/OISF/suricata/blob/master/doc/userguide/rules/payload-keywords.rst#byte_extract
byte_extract implements some optional args:
https://github.com/OISF/suricata/blob/master/src/detect-byte-extract.c#L276
Should be able to copy the doc together from byte_jump fairly trivially, see https://github.com/OISF/suricata/blob/master/doc/userguide/rules/payload-keywords.rst#byte_jump
I can provide a PR once I get around to it.
Updated by Victor Julien over 4 years ago
- Status changed from In Review to Assigned
@Jeff Lucovsky you've been doing some work in this area. Pinging you to make sure we're not duplicating efforts.
Updated by Roland Fischer over 4 years ago
No worries. Have not done anything yet. ;) We'll wait what Jeff is coming back with.
Updated by Roland Fischer about 4 years ago
- Status changed from Assigned to Closed
That was fixed in https://github.com/OISF/suricata/pull/5080 and merged with https://github.com/OISF/suricata/pull/5115
Closing this task.