Bug #3814: Coverity scan issue -- null pointer deref in ftp logger - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #3814

closed

Coverity scan issue -- null pointer deref in ftp logger

Added by Jeff Lucovsky over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jeff Lucovsky

Target version:

6.0.0beta1

Affected Versions:

6.0.0beta1

Effort:

Difficulty:

Label:

Description

** CID 1465225:  Null pointer dereferences  (FORWARD_NULL)

________________________________________________________________________________________________________
*** CID 1465225:  Null pointer dereferences  (FORWARD_NULL)
/src/output-json-alert.c: 567 in AlertJson()
561                         break;
562                 }
563             }
564     565             /* including fileinfo data is configured by the
metadata setting */
566             if (json_output_ctx->flags & LOG_JSON_RULE_METADATA) {
>>>     CID 1465225:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "p->flow" to "AppLayerParserGetFiles", which dereferences it.
567                 FileContainer *ffc = AppLayerParserGetFiles(p->flow,
568                         p->flowflags & FLOW_PKT_TOSERVER ?
STREAM_TOSERVER:STREAM_TOCLIENT);
569                 if (ffc != NULL) {
570                     File *file = ffc->head;
571                     bool isopen = false;
572                     while (file) {

** CID 1465224:  Control flow issues  (DEADCODE)
/src/output-json-ftp.c: 151 in EveFTPLogCommand()